Try and read package name from rescript.json if package.json is not present #7746
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/win32-x64
commit: |
nojaf
force-pushed
the
fallback-name-rescript-json
branch
from
400ebbc to
2548ec5
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds fallback functionality to read package names from rescript.json when package.json is not present, supporting use cases like Deno projects that don't use npm package files.
- Modified
read_package_namefunction to check forpackage.jsonexistence before reading - Added fallback to read from
rescript.jsonwhenpackage.jsonis missing - Updated changelog to document the enhancement
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rewatch/src/build/packages.rs | Added conditional logic to fallback to rescript.json when package.json is absent |
| CHANGELOG.md | Added entry documenting the new fallback behavior |
fhammerschmidt
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use-case which @jderochervlk has with Deno.
@jfrolich setup is the following:
User has no
package.json, so we fallback to rescript.json for the name.Do you see any problems with this?